Merged
Conversation
Member
adam-fowler
commented
Jan 9, 2025
adam-fowler
commented
- Removed unnecessary meters
- Renamed metrics label variables
adam-fowler
commented
Jan 9, 2025
| dimensions: [ | ||
| ("status", JobMetricsHelper.JobStatus.completed.rawValue) | ||
| ] | ||
| ).increment() |
Member
Author
There was a problem hiding this comment.
The value in this meter can be accessed from counter swift.jobs with dimension status set to completed
adam-fowler
commented
Jan 9, 2025
| Meter( | ||
| label: JobMetricsHelper.discardedMeter, | ||
| Counter( | ||
| label: JobMetricsHelper.discardedCounter, |
Member
Author
There was a problem hiding this comment.
Given the value never goes down we can convert this to a counter
thoven87
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.